feat: classify authorization-required errors - #1056
Open
DaleSeo wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
T-documentation
DaleSeo
force-pushed
the
fix/issue-795-auth-error
branch
2 times, most recently
from
July 27, 2026 17:52
bc1d788 to
872c35d
Compare
DaleSeo
force-pushed
the
fix/issue-795-auth-error
branch
from
July 27, 2026 18:18
872c35d to
ec4c0cc
Compare
DaleSeo
marked this pull request as ready for review
July 27, 2026 22:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #795.
Motivation and Context
OAuth initialization can currently ask the caller to authorize through either
AuthError::AuthorizationRequiredorStreamableHttpError::AuthRequired. BecauseClientInitializeErrorerases the concrete transport error, callers must downcast it and match both variants even though both require the same action.This PR classifies those existing errors through their standard source chain and exposes one predicate on
ClientInitializeError. The transport-level classifier remains crate-private so this does not introduce a broader error-category API without a demonstrated use case.How Has This Been Tested?
Add tests
Breaking Changes
None.
Types of changes
Checklist